search

googlecodelabs / your-first-pwapp

Code associated with Your First Progressive Web App codelab
https://g.co/codelabs/pwa
Apache License 2.0
638 stars 555 forks source link

Needless "removeAttribute" #118

Closed angel-luis closed 5 years ago

angel-luis commented 6 years ago

I think that is needless have this line:

app.container.removeAttribute('hidden');

Because the container element never have a hidden attribute.

petele commented 5 years ago

Hi!

Thanks for the feedback. I've rewritten the codelab from scratch and believe I have fixed this issue. The code has been updated, and the new guide is now live.

If you find any issues with the new codelab, please let us know!

Thanks!