googlecodelabs / your-first-pwapp

Code associated with Your First Progressive Web App codelab
https://g.co/codelabs/pwa
Apache License 2.0
638 stars 555 forks source link

Failed to load resource #146

Closed unitedonline closed 5 years ago

unitedonline commented 5 years ago

Failed to load resource: net::ERR_NAME_NOT_RESOLVED [https://query.yahooapis.com/v1/public/yql?format=json&q=select%20*%20from%20weather.forecast%20where%20woeid=2357536]

douglas-kenji commented 5 years ago

yahoo api has been retired on 01/03/2019,to make it work again you will need an API from another weather channel and modify the code to have compatibility with your new API

andytanghr commented 5 years ago

I submitted a pull request that updates this code lab for the new Yahoo API. Check it out here: https://github.com/googlecodelabs/your-first-pwapp/pull/147

dlgiant commented 5 years ago

It worked well with @andytanghr fixes, but I wonder if locally the jQuey file was not loaded with async. $ could only be recognized after removed the async.

petele commented 5 years ago

Hi!

Thanks for the feedback. I've rewritten the codelab from scratch and believe I have fixed this issue. The code has been updated, I'm just waiting for the guide to go live. In the meantime, I've deployed the codelab at https://developers.google.com/web/fundamentals/codelabs/your-first-pwapp/.

If you find any issues with the new codelab, please let us know!

Thanks!