Why are we bumping the cache name/deleting old caches if we're using an incognito window each time?

googlecodelabs / your-first-pwapp

Code associated with Your First Progressive Web App codelab

https://g.co/codelabs/pwa

Apache License 2.0

638 stars 555 forks source link

Why are we bumping the cache name/deleting old caches if we're using an incognito window each time? #15

Closed domenic closed 5 years ago

domenic commented 8 years ago

This idea of bumping the cache name and deleting old caches really threw off my beta-tester. She also doesn't understand why we're doing this given the advice earlier to use an incognito window all the time.

petele commented 8 years ago

You need to bump it so that real world users of the app will get their stuff updated. Incognito is only for testing.

ithinkihaveacat commented 8 years ago

I don't think incognito mode is a good solution: it doesn't support push notifications (and so can't be used if the codelab is ever extended to add notifications) and using it for development is otherwise discouraged anyway. (Though I wish this wasn't the case.)

I think the codelab should instead explain and recommend the use of use Chrome profiles.

petele commented 5 years ago

Hi!

Thanks for the feedback. I've rewritten the codelab from scratch and believe I have fixed this issue. The code has been updated, and the new guide is now live.

If you find any issues with the new codelab, please let us know!

Thanks!