Weather link no worky in Google "First PWA" tutorial

[vincentwansink]

Going through Google's PWA tutorial here: https://codelabs.developers.google.com/codelabs/your-first-pwapp/#4

At a certain point it wants the app to get weather data from Yahoo using this link: https://query.yahooapis.com/v1/public/yql?format=json&q=

That link is no longer valid, so the weather app don't work. Don't know what the new link should be.

[jackeymason]

Thanks for putting this together!

Yahoo's weather api didn't list a call that takes a DB query, so that needs to be changed. Maybe use: https://weather-ydn-yql.media.yahoo.com/forecastrss?location=city,state or https://weather-ydn-yql.media.yahoo.com/forecastrss?woeid=id

[vincentwansink]

Thanks for that but plugging in either of those URLs, as is, doesn't work. The original URL was appended with a query, hence the "q=". Not sure how to make those other URLs you suggest work, but I think using either one of them would require other changes to the tutorial as well.

[jackeymason]

For sure. Those might not even be the best URLs to start with to reduce tutorial code churn. Sorry, I should have provided a full answer. When I get back to the tutorial I try to provide a full and simple solution if possible.

Jack

On Tue, Apr 9, 2019 at 7:56 PM Vincent Wansink notifications@github.com wrote:

Thanks for that but plugging in either of those URLs, as is, doesn't work. The original URL was appended with a query, hence the "q=". Not sure how to make those other URLs you suggest work, but I think using either one of them would require other changes to the tutorial as well.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/googlecodelabs/your-first-pwapp/issues/150#issuecomment-481482413, or mute the thread https://github.com/notifications/unsubscribe-auth/ABU_yE0h4TfZcQ_DsMdIQxIF_DWXtmbSks5vfSibgaJpZM4cjUNa .

[beadon1]

yep, it looks like the APIs were retired on Jan 3, 2019.

see : https://developer.yahoo.com/weather/

Would love to see an updated guide !

[petele]

Hi!

Thanks for the feedback. I've rewritten the codelab from scratch and believe I have fixed this issue. The code has been updated, I'm just waiting for the guide to go live. In the meantime, I've deployed the codelab at https://developers.google.com/web/fundamentals/codelabs/your-first-pwapp/.

If you find any issues with the new codelab, please let us know!

Thanks!

[vincentwansink]

Great job on the new tutorial! Really thorough and accurate. No complaints. Love the suggestion to use Glitch.

Only thing I noticed that is not 100% accurate is on the "install experience" page (https://codelabs.developers.google.com/codelabs/your-first-pwapp/#6) you said that on Windows PWAs must be uninstalled through Chrome. That's not exactly true, as Windows generates the app with a three dot menu next to the minimize/maximize buttons in the title bar and in that menu there is an option to "Uninstall Weather..."

[petele]

Awesome - thanks, I've filed a new issue to track that!

[jackeymason]

Thank you. I'lll give it a go.

Jack

On Fri, Apr 19, 2019 at 3:41 PM Pete LePage notifications@github.com wrote:

Hi!

Thanks for the feedback. I've rewritten the codelab from scratch and believe I have fixed this issue. The code has been updated, I'm just waiting for the guide https://g.co/codelabs/pwa to go live. In the meantime, I've deployed the codelab at https://developers.google.com/web/fundamentals/codelabs/your-first-pwapp/.

If you find any issues with the new codelab, please let us know!

Thanks!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/googlecodelabs/your-first-pwapp/issues/150#issuecomment-484995990, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKT7SDRUMGHRWN7PRIQXILPRIN6VANCNFSM4HENINNA .