googlecodelabs / your-first-pwapp

Code associated with Your First Progressive Web App codelab
https://g.co/codelabs/pwa
Apache License 2.0
638 stars 555 forks source link

fix: Add dotenv support for localhost #169

Closed ianvieira closed 5 years ago

ianvieira commented 5 years ago

Adds the dotenv package to create the same support for localhost running and for glitch, making the support consistent between both.

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

ianvieira commented 5 years ago

Signed CLA

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

petele commented 5 years ago

Hi - thanks for the PR! I've been trying to keep the codelab simple, with as few requirements as possible. Adding dotenv looks pretty low cost, but for now, I'm going to not add it. Developers can easily update the server.js if they want to experiment from their own computer.