search

googlecodelabs / your-first-pwapp

Code associated with Your First Progressive Web App codelab
https://g.co/codelabs/pwa
Apache License 2.0
638 stars 555 forks source link

indexOf() === 0 could be startsWith #17

Closed domenic closed 5 years ago

domenic commented 8 years ago 
if (e.request.url.indexOf(dataUrl) === 0)

could be

if (e.request.url.startsWith(dataUrl))

Every browser that supports service workers supports startsWith.

petele commented 5 years ago

Hi!

Thanks for the feedback. I've rewritten the codelab from scratch and believe I have fixed this issue. The code has been updated, and the new guide is now live.

If you find any issues with the new codelab, please let us know!

Thanks!