search

googlecodelabs / your-first-pwapp

Code associated with Your First Progressive Web App codelab
https://g.co/codelabs/pwa
Apache License 2.0
638 stars 555 forks source link

"Show Live" UI label and behavior changed #170

Closed myakura closed 5 years ago

myakura commented 5 years ago

in https://codelabs.developers.google.com/codelabs/your-first-pwapp/index.html?index=..%2F..io2019#1 it says:

  1. Click the Show Live button to see the PWA in action.

However the button is slightly changed.

opening up "show" popup in Glitch shows two submenu: one is "in a new window", and another is "next to the code"

Now you can see the editor and app side by side, which makes the codelab easier to proceeed, but I guess the prose needs a tweak.

myakura commented 5 years ago

oops, with the current pwa codelab starter, the weather app shown in a frame using "Next to The Code" won't work. I guess that iframe is culprit?

petele commented 5 years ago

Oh good call! Updated, thanks for the tip.