googlecodelabs / your-first-pwapp

Code associated with Your First Progressive Web App codelab
https://g.co/codelabs/pwa
Apache License 2.0
638 stars 555 forks source link

`CODELAB:` marker incorrect for `FILES_TO_CACHE` section #172

Closed Insulince closed 5 years ago

Insulince commented 5 years ago

I noticed in most of the copy/paste snippets there seem to be markers in the code where the lab wants us to paste the snippet. The locations are signified using CODELAB: followed by a message. I believe the marker used for the FILES_TO_CACHE section in part 5 is incorrect, it is pointing to the marker: // CODELAB: Update cache names any time any of the cached files change. When it probably was supposed to be: // CODELAB: Add list of files to cache here.

petele commented 5 years ago

Updated, thanks for the tip!