search

googlecodelabs / your-first-pwapp

Code associated with Your First Progressive Web App codelab
https://g.co/codelabs/pwa
Apache License 2.0
638 stars 555 forks source link

A single hasRequestPending flag seems really broken #20

Closed domenic closed 5 years ago

domenic commented 8 years ago

Given that you can request more than one city in parallel, a single global flag on the app for whether there's a pending request seems like it will mess things up pretty bad.

petele commented 8 years ago

Oh... Yah, that's a problem. Thanks for catching it.

petele commented 5 years ago

Hi!

Thanks for the feedback. I've rewritten the codelab from scratch and believe I have fixed this issue. The code has been updated, and the new guide is now live.

If you find any issues with the new codelab, please let us know!

Thanks!