Delete unnecessary files from repo

googlecodelabs / your-first-pwapp

Code associated with Your First Progressive Web App codelab

https://g.co/codelabs/pwa

Apache License 2.0

638 stars 555 forks source link

Delete unnecessary files from repo #3

Closed petele closed 8 years ago

petele commented 8 years ago

The following files aren't needed for the codelab and should be deleted to not confuse students:

[x] resources/final-gulpfile.js
[x] resources/package.json
[ ] firebase.json
[x] generate-sw.js
[x] gulpfile.js
[x] index.html (in root only)
[x] make-zip.sh
[x] package.json
[x] server.js

I also believe that /images and /styles can be yanked, but will file a separate issue for those two.

mco-gh commented 8 years ago

All unnecessary files deleted except for firebase.json, which is still required for deployment (step 8).

petele commented 8 years ago

We still need firebase.json removed otherwise students/participants can't run firebase init on their own as it blocks on an existing firebase.json file in the directory.

mco-gh commented 8 years ago

Would it be ok if I hide it somewhere? :) Like in the resources dir? Or should we just kill it?

petele commented 8 years ago

Hiding it is prob fine. At some point we're going to need to add back a few of the files we deleted (since they're needed for sw-precache, etc), but for the next couple of weeks it should be fine.

mco-gh commented 8 years ago

fixed by moving firebase.json into the resources directory.