https://localhost instead of http://localhost

googlecodelabs / your-first-pwapp

Code associated with Your First Progressive Web App codelab

https://g.co/codelabs/pwa

Apache License 2.0

638 stars 555 forks source link

https://localhost instead of http://localhost #42

Closed ithinkihaveacat closed 5 years ago

ithinkihaveacat commented 8 years ago

In step 6.

DainialPadraig commented 8 years ago

This definitely needs more explanation. The code lab keeps emphasizing the need for SSL, but step 6 registers and runs the service worker even though Web Server for Chrome isn't capable of serving an https page. Does this mean that TLS is just strongly recommended, or is it actually a requirement for service workers in a production requirement (not localhost)?

johvin commented 7 years ago

@DainialPadraig I think the article Prefer Secure Origins For Powerful New Features can answer your question.

petele commented 5 years ago

Hi!

Thanks for the feedback. I've rewritten the codelab from scratch and believe I have fixed this issue. The code has been updated, and the new guide is now live.

If you find any issues with the new codelab, please let us know!

Thanks!