search

googlecodelabs / your-first-pwapp

Code associated with Your First Progressive Web App codelab
https://g.co/codelabs/pwa
Apache License 2.0
638 stars 555 forks source link

Step 7 - app.updateForecastCard code snippet - Grammar #78

Closed jinalex closed 5 years ago

jinalex commented 7 years ago 
// Bail if the card has more recent data then the data

In this comment 'than' should be used in place of 'then'. Additionally the comment should specify 'recent data' refers to the data in cardLastUpdated and 'the data' refers to data passed through app.updateForecastCard to avoid confusion.

petele commented 5 years ago

Hi!

Thanks for the feedback. I've rewritten the codelab from scratch and believe I have fixed this issue. The code has been updated, and the new guide is now live.

If you find any issues with the new codelab, please let us know!

Thanks!