search

googlecodelabs / your-first-pwapp

Code associated with Your First Progressive Web App codelab
https://g.co/codelabs/pwa
Apache License 2.0
638 stars 555 forks source link

Images could be base64 encoded data URIs #89

Closed mrbusche closed 5 years ago

mrbusche commented 7 years ago

Instead of requiring images in the caching we could create base64 encoded data URIs and add those to the css file. I would be willing to do this as long as it's something you are looking for.

petele commented 5 years ago

Hi!

Thanks for the feedback. I've rewritten the codelab from scratch and believe I have fixed this issue. The code has been updated, and the new guide is now live.

If you find any issues with the new codelab, please let us know!

Thanks!