search

googlecodelabs / your-first-pwapp

Code associated with Your First Progressive Web App codelab
https://g.co/codelabs/pwa
Apache License 2.0
638 stars 555 forks source link

Should Indicate that SW Cache Needs Refresh to View #96

Closed kkruups closed 5 years ago

kkruups commented 7 years ago

Problem:

Service Worker Cache Storage does not automatically refresh in chrome Application Panel

Details

Section 6: Use Service Workers to Pre-Cache the App Shell

Sub-Section: Test It Out

The following excerpt is indicated:

Reload your page and then go to the Cache Storage pane on the Application panel of DevTools. Expand the section and you should see the name of your app shell cache listed on the left-hand side.

However, the app shell cache does not appear listed without a right-click refresh on my system.

Environment System: Win 7 SP1 system Chrome version: 58.0.3029.110 (Official Build) (64-bit)

Expected Fix:

1.Therefore a note should be added to indicate that the Cache Storage icon requires a right-click to access the refresh menu option. This will help reader avoid thinking something is wrong and elimnate countless time of debugging.

or

2.Make it so that the cache automatically refreshes w/o user intervention (or both 1 and 2)

referencing issue: https://github.com/googlecodelabs/your-first-pwapp/issues/94

petele commented 5 years ago

Hi!

Thanks for the feedback. I've rewritten the codelab from scratch and believe I have fixed this issue. The code has been updated, and the new guide is now live.

If you find any issues with the new codelab, please let us know!

Thanks!