googlecolab / colabtools

Python libraries for Google Colaboratory
Apache License 2.0
2.17k stars 701 forks source link

You dont have permision to save this notebook. #2830

Closed neurall closed 2 years ago

neurall commented 2 years ago

Describe the current behavior Suddenly can't save my own notebook I created. File/Save produces err msg box with this text

Cannot save changes You do not have permission to save this notebook. To keep your changes, make a copy of the notebook.

my commit history contains 3th entry where on remote github ipynb was deleted after pushing to wrong repo. maybe this confused colabs internal state and it no longer thinks I am the author, but then who is ?

May 26, 2022 5:51 PM neurall Created using Colaboratory May 18, 2022 11:05 PM neurall Created using Colaboratory May 18, 2022 10:57 PM neurall Delete nvdiffrec.ipynb May 18, 2022 10:49 PM neurall Created using Colaboratory

Describe the expected behavior Save of my own notebook where I am the author should work

What web browser you are using Chrome 104.0.5075.0 (Official Build) canary (64-bit)

Additional context Link to a minimal, public, self-contained notebook that reproduces this issue. [ - Share the file using your GitHub account using File > Save a copy as a GitHub Gist.

cperry-goog commented 2 years ago

Can you confirm: You're encountering this error when you attempt to commit to GitHub? You're committing with the same user as before?

corrieann commented 2 years ago

I dug in a bit and this sounds like Colab doesn't realize you're neurall. If you continue having problems it may help to have Colab forget your GitHub auth information to require you to go through the OAuth flow again: image and then refresh.

neurall commented 2 years ago

Can you confirm: You're encountering this error when you attempt to commit to GitHub? You're committing with the same user as before?

It seems like I am still logged IN as neurall ? since commits to neurall repo work ? image

image

Save commit to github works without issue and offers correct repo name in combo. But normal Ctrl-S or File -> save doesn't Which is weird

image save in github indeed creates new save entry in notebooks own version history image but Ctrl-S produces error again image

I just did clicked revoke github access and then forget in github section of settings as advised Save error was produced even when github is disconnected. Then authorized again but save error stays.

It seems that by deleting notebook from github repo PlenoxelsColab and committing it to repo nvdiffrecColab something in colab broke?

I just deleted in browser session,local storage,cookies logged on again and hard reloaded page without cache but error is still there even on different browser so seems like backend db issue.

I guess solution would be create new colab and copy paste code there but I will keep this one up for you guys to check the problem

corrieann commented 2 years ago

Thanks! We do have a tracking bug for this behavior.

Basically there's no way to save or auto-save to GitHub right now. All saving has to go through the "Copy to GitHub" behavior, because we only support commits to GitHub, not pull requests. So, to save, you would just pretend to be copying to GitHub in the same branch,file, etc. and it should work.

Apologies for the poor UX here. Improving this is on our roadmap.

neurall commented 2 years ago

But I was not trying to save to GitHub but to backend hosting and serving Colab notebook. I.e Classic ctrl-s /file->save. That functionality was there before. Saving to github makes sense only when things are ready for sharing with community which is not role of file/save I guess.