search

googlecreativelab / aiexperiments-ai-duet

A piano that responds to you.
https://aiexperiments.withgoogle.com/ai-duet
1.63k stars 283 forks source link

Fixed issue with generate params and midi output params #1

Closed camiblanch closed 7 years ago

camiblanch commented 7 years ago

Without this fix I was unable to get anything other than uncaught errors using python 2.7. Once I fixed the params, everything worked smoothly.

gnestor commented 7 years ago

This fixes https://github.com/googlecreativelab/aiexperiments-ai-duet/issues/2 for me!

andrew-c-edwards commented 7 years ago

This gets the basic code to run, but if you try to use a different RNN you'll run into problems. See discussion in #2 . A better temp fix is to move third_party/magenta up a level to simply magenta ... In there, there is an implementation of generate that takes a GenerateSequenceRequest object.

Hdooster commented 7 years ago

@andrew-c-edwards your fix worked as well for me (2.7), thanks!