Datalab offers optional upgrade to 1.2.20180713 which does not exist in GitHub releases

googledatalab / datalab

Interactive tools and developer experiences for Big Data on Google Cloud Platform.

Apache License 2.0

974 stars 249 forks source link

Datalab offers optional upgrade to 1.2.20180713 which does not exist in GitHub releases #2044

Closed chc8 closed 6 years ago

chc8 commented 6 years ago

Datalab was very slow to start today. I was presented with the option to update datalab to version 1.2.20180713. The "what's new" link beside the message was for Github datalab releases. The datalab release page does not have a release for version 1.2.20180713.

Is 1.2.20180713 a legitimate datalab update?

I also posted this question on StackOverflow. Since the issue seems like it might be related to GitHub I am also posting it here.

question asked on StackOverflow

yebrahim commented 6 years ago

Yes this is the latest release, I just created the release tag.

What sort of slowness are you experiencing? Can you add more details?

chc8 commented 6 years ago

Today a few people on my team opened datalab this morning with issues.

For myself I noticed:

At first datalab loaded to a blank page (still a datalab page, but no directory). A browser refresh loaded the directory and menu.
The datalab page in the browser was taking many minutes to load (browser showing busy). The menu/file/folder icons were missing, but there were text descriptions instead. After waiting for datalab to load the icons appeared.
After restarting my datalab VM the slow loading behavior continued.
The message offering an upgrade to 1.2.20180713 was new since the last time I used datalab.

yebrahim commented 6 years ago

Interesting. I've just tested the new release again and it works fine for me, the difference between my setup and yours probably being due to your updating your instance, while I created a new one. Can you try a new instance and add your findings here?

Also, do you by any chance remember which version of Datalab you had before the update?

chc8 commented 6 years ago

I have not updated yet. Currently I am on version 1.2.20180511. I see the message offering an optional update to 1.2.20180713.

I performed a "reset" on my datalab VM and the same issues occurred with a blank datalab page at first. After changing the URL to point at the /datalab directory (from a deeper directory), and refreshing the browser, then the datalab page correctly loaded.

yebrahim commented 6 years ago

Is that reproducible? Does the /datalab directory always load quickly compared to a deeper path? And does the slowness continue long after resetting the VM or is it just for a while then goes away?

Also related: I wonder if you have a big tree of files, it could be that our file indexing is slowing down the instance on startup. We haven't seen reports of this happening before though.

chc8 commented 6 years ago

It seems to be Intermittently reproducible while randomly browsing inside of datalab directories.

I have not experienced this problem previously to today.

I would be glad to give you more information. I also could just try upgrading to 1.2.20180713.

yebrahim commented 6 years ago

Can you try opening the developer tools in your browser (ctrl/cmd+shift+i on chrome) and refreshing the page while looking at the network tab to see which resource is taking that long to load?

chc8 commented 6 years ago

The issue has gone away without any action taken on my behalf. The worse offender today was 3.94s, and that only happened once out of roughly 20 attempts to reproduce the issue. Yesterday it was minutes of waiting.

timing 2018-07-17_12-30-20

yebrahim commented 6 years ago

My suspicion was that it's a dependency that we load from a CDN that just had a bad day. The screenshot here just seems like a random network issue if it's rare and only takes a couple more seconds than usual.

If this happens again, please try to capture the offending resource and feel free to create a new issue. I'll close this one for now.