googledatalab / datalab

Interactive tools and developer experiences for Big Data on Google Cloud Platform.
Apache License 2.0
975 stars 249 forks source link

Timeout Datalab connections if they never become healthy #2056

Closed ojarjur closed 6 years ago

ojarjur commented 6 years ago

This change adds a timeout to the health check, after which the SSH tunnel will be killed (triggering it to be recreated), if the health check never succeeds before that timeout.

This adds an important check to catch issues where the SSH tunnel itself is unhealthy as opposed to the connecting instance being unhealthy.

This fixes #2051