Open josh-taylr opened 5 years ago
I'm going to need some help to understand why CI failed. What I am reading in the logs is that the spec tests passed 🤔
Seems like flake8 has failed on the cli directory, probably because of a version change in the tool:
$ flake8 cli/
cli/datalab.py:409:12: F632 use ==/!= to compare str, bytes, and int literals
The command "flake8 cli/" exited with 1.
I'll send a separate PR to fix that.
EDIT Created https://github.com/googledatalab/datalab/pull/2122.
This should be fixed now, can you rebase this PR @josh-taylr?
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g.
I signed it!
) and we'll verify it.What to do if you already signed the CLA
Individual signers
Corporate signers
ℹ️ Googlers: Go here for more info.