Removed the creation of the firewall rule for --beta-no-external-ip.

googledatalab / datalab

Interactive tools and developer experiences for Big Data on Google Cloud Platform.

Apache License 2.0

975 stars 249 forks source link

Removed the creation of the firewall rule for --beta-no-external-ip. #2127

Closed mdhedley closed 5 years ago

mdhedley commented 5 years ago

Public firewall creation for no-external-ip doesn't make sense as there will be no external access. Removing the firewall creation for this flag. This resolves both issue #2126 and #2125 .

mdhedley commented 5 years ago

Closing as I messed up by git history. Will resubmit from new fork.