Added --no-firewall-rule

googledatalab / datalab

Interactive tools and developer experiences for Big Data on Google Cloud Platform.

Apache License 2.0

974 stars 249 forks source link

Added --no-firewall-rule #2135

Closed mdhedley closed 5 years ago

mdhedley commented 5 years ago

This creates a new flag --no-firewall-rule which disables firewall rule creation. fixes #2126

TV4Fun commented 5 years ago

@yebrahim or anyone else on the Datalab team, can we get a review on this? The bug this fixes is stopping us from being able to adopt Datalab. I'm not sure why the CI build is failing, but I think it's unrelated to this change.

TV4Fun commented 5 years ago

@yebrahim, @rileyjbauer, this change has been approved. How long to get it merged?