search

googledatalab / pydatalab

Google Datalab Library
Apache License 2.0
194 stars 79 forks source link

Fix an issue that TF Events are not parsed because tf record appears to be corrupted. #710

Closed qimingj closed 6 years ago

qimingj commented 6 years ago

It seems recent TensorFlow introduced the issue again. For some reasons tensorboard still works, and I think they did similar things (ignore the error).

qimingj commented 6 years ago

By the way the tests are failing because of the type script version. Do we need to update the tox environment? @ojarjur @yebrahim

ojarjur commented 6 years ago

@qimingj I don't think it is the tox environment we would need to fix. Instead, I think we need to pin the typescript version on this line

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.04%) to 77.819% when pulling 17cad7d118095c5359cd65761d196d02d0ee00fe on tfevents into a7d2f26e0f7fd5b1918e5f3e34e9550deeae46bd on master.