googlefonts / OswaldFont

repo for the Oswald font family
SIL Open Font License 1.1
71 stars 22 forks source link

Ӊ interpolation issue #20

Open thlinard opened 3 years ago

thlinard commented 3 years ago

https://fonts.google.com/specimen/Oswald?preview.text=%D3%89&preview.text_type=custom

See https://type.today/en/journal/neo

kenmcd commented 3 years ago

This one appears to have already been fixed in the Oswald.glyphs master.

thlinard commented 3 years ago

Oh, indeed! Live version is 4.100 (not fixed), the version here is 4.101 (fixed), with a PR waiting (version 4.102, fixed).

thlinard commented 3 years ago

Hi @aaronbell, do you know what happened? It seemed to me that the problem was corrected in 4.102, but I see that it reappeared by https://github.com/google/fonts/pull/3661 (in Ң and Ӊ). Did this come from when you switched the sources?

aaronbell commented 3 years ago

I pulled the latest version of this repro when creating the new build process. If that source hasn’t been updated then mine wasn’t updated.

If I had to guess, this fix was updated in the unmerged PR from Marc (and wasn’t mentioned in the change notes)?

I can take a look later this week.

aaronbell commented 3 years ago

I'm a bit confused, honestly 😆. The source is correct, the variable font on this repro is correct, but the version that got merged into GF has the issue. No idea how that happened.

thlinard commented 3 years ago

Indeed!

The version in https://github.com/google/fonts/pull/3661 has 129,452 bytes (767 glyphs), and it's supposed to come from https://github.com/aaronbell/OswaldFont, where the file has 172,608 bytes (883 glyphs).

Maybe the easiest way is to do a new PR?

fitojb commented 2 years ago

Just for the record, the issue is still visible on the public Google Fonts catalog.

aaronbell commented 2 years ago

See https://github.com/google/fonts/pull/3893

The PR was blocked for the time being.