search

googlefonts / OswaldFont

repo for the Oswald font family
SIL Open Font License 1.1
71 stars 22 forks source link

Added Cyrillic Glyphs #6

Closed NDISCOVER closed 6 years ago

NDISCOVER commented 6 years ago

Added Cyrillic Glyphs + Started Kerning Revision

NDISCOVER commented 6 years ago

@davelab6 here is the pull request :)

davelab6 commented 6 years ago

The red ones will be added in the next few weeks

On Oct 29, 2017 9:56 AM, "Marc Foley" notifications@github.com wrote:

@m4rc1e commented on this pull request.

@NDISCOVER https://github.com/ndiscover @davelab6 https://github.com/davelab6 Are there mean't to be this many missing glyphs?

[image: screen shot 2017-10-29 at 13 53 04] https://user-images.githubusercontent.com/7525512/32144430-9aa0d0ca-bcb0-11e7-9642-2a0bf085a647.png

In the .glyphs files there are many cells which are marked red with empty outlines. Can these be deleted?

I see you have completed the list we sent you. [image: screen shot 2017-10-29 at 13 55 44] https://user-images.githubusercontent.com/7525512/32144448-e28185c4-bcb0-11e7-8ac9-9112bcd99dd1.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/googlefonts/OswaldFont/pull/6#pullrequestreview-72698255, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP9y_Z51BbbpI_lent7-P5bfezhdC1yks5sxIQLgaJpZM4QJSEr .

m4rc1e commented 6 years ago

@davelab6 If we need this for next week. shall I remove the red glyphs and send a pr to google/fonts?

If so, please merge this pr (I'm happy with it) and I will polish it.

davelab6 commented 6 years ago

You can just mark the red glyphs as not for export

On Oct 29, 2017 2:18 PM, "Marc Foley" notifications@github.com wrote:

@davelab6 https://github.com/davelab6 If we need this for next week. shall I remove the red glyphs and send a pr to google/fonts?

If so, please merge this pr (I'm happy with it) and I will polish it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/googlefonts/OswaldFont/pull/6#issuecomment-340282602, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP9y1khG31tLeajiZtswJqxZwz11Jxrks5sxMFngaJpZM4QJSEr .

davelab6 commented 6 years ago

And yes this is needed asap

On Oct 29, 2017 4:37 PM, "Dave Crossland" dave@lab6.com wrote:

You can just mark the red glyphs as not for export

On Oct 29, 2017 2:18 PM, "Marc Foley" notifications@github.com wrote:

@davelab6 https://github.com/davelab6 If we need this for next week. shall I remove the red glyphs and send a pr to google/fonts?

If so, please merge this pr (I'm happy with it) and I will polish it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/googlefonts/OswaldFont/pull/6#issuecomment-340282602, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP9y1khG31tLeajiZtswJqxZwz11Jxrks5sxMFngaJpZM4QJSEr .

alexeiva commented 6 years ago

The Cyrillic looks good enough for a quick first release as is. I will prepare a specific fine-tuning review that you can implement in the next update.