cjdunn
commented
4 years ago These issues are fixed via this PR: https://github.com/TypeNetwork/Raleway/pulls
Closed gf-bot closed 4 years ago
cjdunn
commented
4 years ago These issues are fixed via this PR: https://github.com/TypeNetwork/Raleway/pulls
I just proofed the two VFs in branch ufo-fea-conv2. Both still contain MVAR tables and they also need to be run through
fix-hinting.build.sh is running fix-hinting on the VFs then running fix-nonhinting. In this case, only fix-hinting should be run since the fonts have been run through ttfa.
Please include a requirements.txt file in the parent dir of the repo which lists what fontmake version was used and our gftools installation command e.g:
Remove the glyphs files from the source dir. We only want one set of sources.
Font names are wrong. Your .py script to fix it just hides the issue. If I convert the ufos back to a .glyphs, we can see the masters are named incorrectly.
Masters should be named after which instances they represent. In this case, Light should be Thin, Regular should be Medium and Bold should be Black. If you follow the above naming, you won't need your fix script.
fractions may be too wide, especially threequarters. I could be wrong here.
love the new double story 'a'. More than happy to see if this breaks the internet.
Once you've fixed the above, I'll review the fonts again. It would also be nice to generate the fonts into a new dir in the fonts dir called vf.
cc @davelab6