search

googlefonts / RobotoMono

Apache License 2.0
100 stars 16 forks source link

Some fonts use foundry "pyrs" instead of "GOOG" #23

Open ambihelical opened 3 years ago

ambihelical commented 3 years ago

I think this is causing an app I use (emacs) to be unable to use italic. I don't know much about fonts, so I could be way off on this. I'm sure it could be argued that it should not matter, and emacs is buggy, but this looks like a mistake to me, and maybe it will fix the issue. 

▶ rg pyrs
------------------------- Sun Sep 27 16:02:35 PDT 2020 -------------------------------
RobotoMono-BoldItalic.ufo/fontinfo.plist
118:    <string>pyrs</string>

RobotoMono-ThinItalic.ufo/fontinfo.plist
118:    <string>pyrs</string>

RobotoMono-Italic.ufo/fontinfo.plist
118:    <string>pyrs</string>
▶ rg GOOG
------------------------- Sun Sep 27 16:02:40 PDT 2020 -------------------------------
RobotoMono-Bold.ufo/fontinfo.plist
149:    <string>GOOG</string>

RobotoMono-Regular.ufo/fontinfo.plist
149:    <string>GOOG</string>

RobotoMono-Thin.ufo/fontinfo.plist
149:    <string>GOOG</string>
ambihelical commented 3 years ago

UPDATE: after using a binary editor to change pyrs to GOOG in the offending ttf files, this did resolve the issue with emacs and Roboto-Mono. It would be great if there was an official release with this change.

petergardfjall commented 3 years ago

I saw the exact same behavior: Emacs failing to render/recognize the italic variants of the font due to the inconsistent vendor ID. I opened a PR: https://github.com/googlefonts/RobotoMono/pull/30