Diacritics improvements needed

[vv-monsalve]

Hi @crystaltype, after pulling the latest source file and producing the new font, there are still some diacritics issues. Please inspect the following and the list in the Font Mastering Issue to address all the improvements needed in the font.

• [ ] The combining marks created have gone way too up of the base glyph, they should be at a hight similar to the original position of the font. Please add the original glyphs to the background as a reference.
• [ ] All the composite glyphs should be produced combining a base glyph + comb mark
• [ ] DIacritics should be aligned
• [ ] Subtly balancing the overall thickness, size and visual weight among marks. E.g., the circumflex seems to be lighter or smaller than acute or grave
• [ ] Balancing the sidebearing/spacing of the marks to prevent them to alter the spacing of the composite glyphs
• [ ] Stacked diacritics distance and position should be balanced
• [ ] Uppercase diacritics comb.case are needed for Caps as they differ in size and thickness

Original diacritics

Current diacritics

Stacked diacritics before

Stacked diacritics after

[vv-monsalve]

before

after

• The overall thickness of the diacritics has improved, however, some of them could look a bit heavy (e.g. circumflex), please include some of the contrast of the original marks to recover a bit of the lightness.

• Case diacritics tend to be slightly different from the lowercase ones. Usually, they are more sloped to avoid being too tall, circumflex or caron has a wider angle, thus they could be a bit wider than lc-marks to compensate the angle and to not look small for their base letters, among others.

[crystaltype]

I improved the diacritics per your suggestions. I think Alexbrush is now ready to be published.

[vv-monsalve]

Hi @crystaltype,

Please inspect caron and macron that seem lighter than the other marks, and circumflexgrave plus circumflexacute look as if they were touching.

I tried to pull the latest files but they are not in the repo, please push them so I can generate new preview and comparative images.

[crystaltype]

Hello @vv-monsalve

I've fixed them.

I tried to pull the latest files but they are not in the repo, please push them so I can generate new preview and comparative images.

Hmm I used git push command, do I need to make a pull request too?

[vv-monsalve]

Hmm I used git push command, do I need to make a pull request too?

Probably you pushed to your fork but not to this upstream folder, when looking at the list of commits the last was mine 17 days ago.

What would be best to keep the process clean is you could keep pushing to your fork but remember to PR to this repository, which is the traditional workflow in any case.