search

googlefonts / colr-gradients-spec

63 stars 8 forks source link

DO NOT MERGE: Draft for PaintSweepGradient update #362

Open drott opened 2 years ago

PeterConstable commented 2 years ago

See #363 for suggested alternate image.

PeterConstable commented 2 years ago

After we've reviewed and have consensus, we still should wait on merging as we'll need to prepare a separate doc for submission to the MPEG AHG as proposed revision for the new edition. (It's too late to make changes in Amd 2.)

drott commented 2 years ago

After we've reviewed and have consensus, we still should wait on merging as we'll need to prepare a separate doc for submission to the MPEG AHG as proposed revision for the new edition. (It's too late to make changes in Amd 2.)

Are you suggesting to wait with merging until the MPEG AHG has accepted the proposed change, too?

drott commented 2 years ago

See #363 for suggested alternate image.

See comment above, updated figures with more clearly separating the color stops.

drott commented 2 years ago

@justvanrossum Would you have time to review this as well and see if this resolves any ambiguities from our discussion in https://github.com/BlackFoundryCom/black-renderer/issues/17? Thanks in advance.

PeterConstable commented 2 years ago

Are you suggesting to wait with merging until the MPEG AHG has accepted the proposed change, too?

No, that's not what I meant. These revisions are in OFF_AMD2_WD, which was proposed content for Amendment 2 of OFF. But it's too late to make further changes to amendment 2. So, we'll need to prepare a separate document for that.

vlevantovsky commented 2 years ago

Are you suggesting to wait with merging until the MPEG AHG has accepted the proposed change, too?

No, that's not what I meant. These revisions are in OFF_AMD2_WD, which was proposed content for Amendment 2 of OFF. But it's too late to make further changes to amendment 2. So, we'll need to prepare a separate document for that.

These changes can only go into the new Working Draft of the next edition OFF, and we do need to submit an input contribution summarizing the proposed changes.

drott commented 2 years ago

@PeterConstable Note sure why GitHub does not let me comment directly in the thread above, but just wanted to point you to the typo in the edited version:

NOTE: To allow for a representation of +360°, a bias of 1.0 is used in the representation of stand start and end angles of sweep gradients. [...]