search

googlefonts / diffbrowsers

Apache License 2.0
8 stars 5 forks source link

Load and diff pre-existing GF Regression sessions. #2

Closed m4rc1e closed 6 years ago

m4rc1e commented 6 years ago

In the previous implementation, users couldn't take diff images of an existing session. Diffbrowsers would only allow new sessions to be created by uploading fresh fonts each time.

In order to facilitate this change. The CLI interface has been updated using argparse's submodules.

If a user would like to diff an existing session, they add load to their command e.g

gfdiffbrowsers load <url> -o ~/Desktop/img_dir

If a user would like to create a new session, they add new to their command e.g

gfdiffbrowsers new <url> [fonts_after] -fb [fonts_before] -o ~/Desktop/img_dir

Some api changes had to be made in order to facilitate this new functionality. Fortunately only one tool relies on this api, the Dispatcher, which is not publicly available yet.

This pr depends on https://github.com/m4rc1e/gfregression/pull/32. This must be merged first.

davelab6 commented 6 years ago

https://github.com/m4rc1e/gfregression/pull/32 was merged, so merging