In the font_update() function, the if xxx: conditionals will evaluate to false for empty values, and will then not update the field. This makes it impossible to clear any of those fields.
I can't find the definition for get_dict(), so I don't know what it returns for a missing argument. There should be a distinction between "argument not given" and "argument is empty".
In the
font_update()
function, theif xxx:
conditionals will evaluate to false for empty values, and will then not update the field. This makes it impossible to clear any of those fields.I can't find the definition for
get_dict()
, so I don't know what it returns for a missing argument. There should be a distinction between "argument not given" and "argument is empty".https://github.com/googlefonts/django-robo-cjk/blob/1db34842ae7e0dd6d850b39ce3c374c20c5b9d5d/robocjk/api/views.py#L224-L242