Closed Colophon-Foundry closed 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
âšī¸ Googlers: Go here for more info.
@googlebot I signed it!
Fontbakery version: 0.7.13
đ ERROR | đĨ FAIL | â WARN | đ¤ SKIP | âš INFO | đ PASS | đ DEBUG |
---|---|---|---|---|---|---|
0 | 38 | 30 | 358 | 31 | 364 | 0 |
0% | 5% | 4% | 44% | 4% | 44% | 0% |
Note: The following loglevels were omitted in this report:
Did you generate each family using the build.sh file in each source dir?
Yep. All built with the build.sh
file. No other processes.
Fonts in master branch have 20 fails. This pr has 38. This includes fails for DSIG and gasp (these are fixed in the build.sh scripts). This leads me to believe the fonts were not generated by running sh build.sh
What's the fontbakery command you're running for the checks?
fontbakery check-googlefonts DMSans* -l FAIL
@m4rc1e I've just re-built these. Think there was an issue with my install of gftools
â I'm getting no regressions this side now.
Fontbakery version: 0.7.13
đ ERROR | đĨ FAIL | â WARN | đ¤ SKIP | âš INFO | đ PASS | đ DEBUG |
---|---|---|---|---|---|---|
0 | 20 | 30 | 352 | 31 | 388 | 0 |
0% | 2% | 4% | 43% | 4% | 47% | 0% |
Note: The following loglevels were omitted in this report:
I'll check if the other fixes have been implemented in the Serif families.
Fontbakery version: 0.7.13
đ ERROR | đĨ FAIL | â WARN | đ¤ SKIP | âš INFO | đ PASS | đ DEBUG |
---|---|---|---|---|---|---|
0 | 6 | 10 | 128 | 11 | 138 | 0 |
0% | 2% | 3% | 44% | 4% | 47% | 0% |
Note: The following loglevels were omitted in this report:
Fontbakery version: 0.7.13
đ ERROR | đĨ FAIL | â WARN | đ¤ SKIP | âš INFO | đ PASS | đ DEBUG |
---|---|---|---|---|---|---|
0 | 6 | 10 | 128 | 11 | 138 | 0 |
0% | 2% | 3% | 44% | 4% | 47% | 0% |
Note: The following loglevels were omitted in this report:
@Colophon-Foundry For DM Display, move the lowercase 'k' join 1 unit please. Everything else is good.
@Colophon-Foundry For DM Display, move the lowercase 'k' join 1 unit please. Everything else is good.
Fixed in 3091472
Fontbakery version: 0.7.13
đ ERROR | đĨ FAIL | â WARN | đ¤ SKIP | âš INFO | đ PASS | đ DEBUG |
---|---|---|---|---|---|---|
0 | 6 | 10 | 128 | 11 | 138 | 0 |
0% | 2% | 3% | 44% | 4% | 47% | 0% |
Note: The following loglevels were omitted in this report:
Thanks!
@m4rc1e Any update on this when we get the fix merged into Google Fonts? I still experience the bug on a site where we use DM Sans and also here on the specimen https://fonts.google.com/specimen/DM+Sans
@m4rc1e Is there any update on saschaeggi's question? Thank you :)
Serif - resolving issues in #6 Sans - resolving issues in #7