Closed waywardmonkeys closed 1 month ago
huh, that seems counterintuitive to me, if the std
feature is disabled why does the presence of std
on the target matter?
In any case thank you for the report, will take a look...
I think the issue is that even if you include the no_std attribute, rustc will happily pull in std if it is used in your dependency graph. Using a std-less target checks the whole compilation.
When int-set
was incorporated into read-fonts
, it was done so behind an std
flag, so that part of things works now. Thanks!
@dfrg was correct. PR #1049 addresses all of this hopefully.
CI checks
no-std
builds forfont-types
,read-fonts
andskrifa
. However, it uses the default target which has anstd
, so this isn't a comprehensive check.These jobs need to specify a target and that needs to not have an
std
implementation. I tend to use one ofthumbv7m-none-eabi
,riscv64imac-unknown-none-elf
, orx86_64-unknown-none
.The
rust-toolchain
action will have to install this target:Once you do that, you'll see that
int-set
doesn't build forno-std
and thereforeread-fonts
doesn't build forno-std
.