Open simoncozens opened 3 weeks ago
Generally the names of fields in read-fonts follows the names in the OpenType specification; so it's confusing when they don't.
read-fonts
The spec has
but hhea.rs has:
hhea.rs
/// Number of LongMetric entries in 'hmtx'/'vmtx' table number_of_long_metrics: u16,
read-fonts's is probably a better name, but it causes a mental "wait, are these the same thing or not?" moment. A doc comment would be helpful.
Generally the names of fields in
read-fontsfollows the names in the OpenType specification; so it's confusing when they don't.The spec has
but
hhea.rshas:read-fonts's is probably a better name, but it causes a mental "wait, are these the same thing or not?" moment. A doc comment would be helpful.