googlefonts / fontbakery-dashboard

A library-scale web dashboard for Font Bakery, no longer developed
Apache License 2.0
28 stars 10 forks source link

Dispatcher: User story for a user submitting a new family #101

Open m4rc1e opened 5 years ago

m4rc1e commented 5 years ago

I've just attempted to upload a new family. I haven't studied any of the source code so my review isn't a deep one. I'm purely looking at the functionality from a user perspective. I was not able to complete the push, however, here's what I noticed.

Task: Dispatch https://github.com/SorkinType/Alatsi

Hope this helps.

graphicore commented 5 years ago

Thanks, definitely.

All valid points. I'll focus in this comment on the last point, because it was the blocking one. Just some thoughts.

At this point, we finished a PR with this family: https://github.com/graphicore/googleFonts/pull/18

The main problem, not finishing the packaging, was caused by the UI, I believe.

Font files were not found at the packaging phase. I had this three times. The first time, I forgot to include the font dir (my fault). The second time, I included the font dir and the font prefix correctly.

The infos entered at that step must be carried over manually into the spreadsheet. Just entering the info into the "register" form does not change the spreadsheet.

Selection_233

The next step should be very clear about this. About what we expect the engineer to do with the submitted information:

Selection_234

Also visible in this screenshot, at the data section on the top, the fontFilesPrefix entry suggests that the data is up to date, but it is merely the value submitted by the user, not the spreadsheet data.

Another UI issue: once the family is registered in the spreadsheet, the dropdown menu Pick one of the update a registered ... form ca be used, as the dropdown lists all families in the spreadsheet. Hence UI should probably ask: "Is the font in the dropdown" (or similar) and if the answer is "no" show the register-form.

Selection_236

davelab6 commented 5 years ago

@graphicore any updates on this? :)