search

googlefonts / fontbakery-dashboard

A library-scale web dashboard for Font Bakery, no longer developed
Apache License 2.0
28 stars 10 forks source link

Feature: work from branches other than master. #115

Closed graphicore closed 5 years ago

graphicore commented 5 years ago

In a designers workflow, they need to check from their working branch and also in a sandboxed environment before going to the (unsandboxed) version with release branch. We can't use branches right now from our spreadsheet info.

see #114

full report

Step # 0 Review the Request and Generate the Files Package

finished: FAILED

Failing with reason: Abandoned because we can't work from custom branches right now.

Task ApproveProcess FAILED

Manifest Server CSVSpreadsheet/upstream can't create files package.

Report…

ERROR Error: unexpected HTTP status code: 404

graphicore commented 5 years ago

One use case for this is to enable #117 — a sandboxed workflow.

Another use case, that we need to discuss (if it isn't documented already): currently it's not possible to specify another branch than master in our spreadsheet database via manifestSources/CSVSpreadsheet. I'm not sure if we require our production upstream repos to have the fonts put into their master branch, but some projects may not want to put binaries into their repositories, so a way could be to have e.g. a google-fonts branch where the binaries for GF would be put in and use that as an upstream for releases targeted at google fonts.

NEXT research: is using master required for our upstream contributions? If yes, where (are the docs/instructions) and why.

graphicore commented 5 years ago

There's now a "branch" row in the spreadsheet that will be used if set. However, to be complete the interface should allow (at least for sandboxed mode) to request a specific branch and also display the branch requested and used in certain user interfaces e.g.:

Screenshot from 2019-08-27 21-13-37

E.g.: the sourceDetails log shows a _branch which is fine right now but the table below doesn't. That info in the table is what the user can request and all those situations where that data is shown or an interface asks for it should be updated to also include branch.

graphicore commented 5 years ago

@vv-monsalve see this process I just initiated: https://fontbakery.graphicore.de/dispatcher/process/f139fe33-e6ea-418f-a28a-4665884d4580

It now uses the branch "QA-Solway" feel free to play with the dispatcher (which is sandboxed now) while I keep working on this and #117

vv-monsalve commented 5 years ago

This is great! I'll do it and let you know if any doubt.

On Tue, 27 Aug 2019 at 14:31, Lasse Fister notifications@github.com wrote:

@vv-monsalve https://github.com/vv-monsalve see this process I just initiated: https://fontbakery.graphicore.de/dispatcher/process/f139fe33-e6ea-418f-a28a-4665884d4580

It now uses the branch "QA-Solway" feel free to play with the dispatcher (which is sandboxed now) while I keep working on this and #117 https://github.com/googlefonts/fontbakery-dashboard/issues/117

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/googlefonts/fontbakery-dashboard/issues/115?email_source=notifications&email_token=ALTRMYEZEWJW5SYDJOMZCSLQGV6IRA5CNFSM4IPSSV6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5I3SHA#issuecomment-525449500, or mute the thread https://github.com/notifications/unsubscribe-auth/ALTRMYG3HI7KR56642U52WTQGV6IRANCNFSM4IPSSV6A .

-- ••••••••••••••••••• VIVIANA MONSALVE Diseñadora Gráfica & Tipográfica • @ _vvmonsalve