googlefonts / fontbakery-dashboard

A library-scale web dashboard for Font Bakery, no longer developed
Apache License 2.0
28 stars 10 forks source link

Regression: GenericProcess doesn't initialize #126

Closed graphicore closed 5 years ago

graphicore commented 5 years ago

We are getting errors like this:

Not found: Error: 2 UNKNOWN: State to load had the following issues: =============== * steps (load): Ctor is not a constructor ===============

on e.g. https://fontbakery.graphicore.de/dispatcher/process/b1878c10-4b0d-4211-8831-48a45945c226

Screenshot from 2019-09-26 20-07-14

GenericProcess is a fallback mechanism: if the data in the database becomes incompatible with the specific Process class (here FamilyPRDispatcherProcess) GenericProcess is used to be able to still display the outdated data, but not manipulate it. This is an important feature to make it possible to evolve the specific Process but still be able to inspect old processes.

The constructor invocations have changed in the abstract Process, Step and Task model, but the changes have not been applied to the GenericProcess classes.

graphicore commented 5 years ago

Works again.

Screenshot from 2019-09-27 01-26-32