googlefonts / fontbakery-dashboard

A library-scale web dashboard for Font Bakery, no longer developed
Apache License 2.0
28 stars 10 forks source link

Dispatcher UI: Browserstack process #138

Open vv-monsalve opened 4 years ago

vv-monsalve commented 4 years ago

Browserstack can take long, so it should be a warning message about this. Also, a way to actually end works that don't respond anymore... although that will be hard to decide

graphicore commented 4 years ago

this is from a chat I had with @vv-monsalve

Also, a way to actually end works that don't respond anymore... although that will be hard to decide

What I meant is something like a timeout or heartbeat for workers. To eventually kill them and to inform the dispatcher with an error message.

m4rc1e commented 4 years ago

In gftools qa, I recently refactored it to speed up diffbrowsers for large families. It now runs on 4 styles at a time. It used to just be 1 style.

https://github.com/googlefonts/gftools/blob/master/bin/gftools-qa.py#L176

graphicore commented 4 years ago

In gftools qa, I recently refactored it to speed up diffbrowsers for large families. It now runs on 4 styles at a time. It used to just be 1 style.

Ok, cool. How does it work? Can you point me to the commits that changed it?

graphicore commented 4 years ago

@m4rc1e: ping (follow up of what I mentioned in the call)