Closed vv-monsalve closed 4 years ago
Technically checking OK because it's not needed to look at that report (e.g. because it's a new family) or because it passes is the same.
However, I changed the UI of the Diffenator tasks to add an explicit SKIP option. It's also noted in the report history which option was chosen, otherwise it's the same result as choosing OK.
NEW:
OLD:
When working with a Font that is new on GF (e.g. this case Gupter) a third option to finish Diffenator task besides Ok or Fail is needed to prevent the PR from stuck.
When ending the process by leaving the "it is ok" checkbox uncheck and with a Note: ("Because the font is new on GF") the task remained as Fail and this seemed to somehow block the PR. https://fontbakery.graphicore.de/dispatcher/process/30cbaadd-3ffd-4536-8168-a7a22073ffd8
On the other hand, the process seemed to work well when it was marked as "Task ApproveProcess OK @vv-monsalve confirms the family package" https://github.com/graphicore/googleFonts/pull/39