search

googlefonts / fontbakery-ui

Apache License 2.0
6 stars 3 forks source link

Migrate into fontbakery repo? #6

Open davelab6 opened 4 years ago

davelab6 commented 4 years ago

I wonder if we should just have this as part of the github.com/googlefonts/fontbakery repo, so its simply fully integrated into the (mostly weekly) releases there

@felipesanches

davelab6 commented 3 years ago

I suggest we transfer this to github.com/googlefonts org; if you transfer to me and chat/email me a note to confirm, I can move it there

simoncozens commented 3 years ago

All yours.

davelab6 commented 3 years ago

Transfer complete; @felipesanches what do you recommend to continue development and keep the UI updated on each FB release?

felipesanches commented 3 years ago

I want to keep it in a separate repo for now. May include in the fontbakery repo later if I consider it a good move. I am not sure yet

davelab6 commented 3 years ago

That's fine with me :)

However, maybe a separate issue: what do you recommend to keep the releases of this repo updated on each FB release?

felipesanches commented 3 years ago

my first step will be to review this codebase to better understand what is its current state. README says "Totally MVP".

After that, I would consider making fontbakery a dependency of this one. And I would add a step to my fontbakery release check-list to also cut a release of the ui in sync.

Maybe the UI does not need to always be updated, since it may be able to import the latest fontbakery package form PyPI. I'll have to double-check if that's really a problem.

But, as I said before, my first concern before anything else is to assess the current status of the code in this repo.

felipesanches commented 3 years ago

note: fontbakery is already listed as a dependency of fontbakery-ui in the requirements.txt file in this repo, which is a good thing ;-)

felipesanches commented 3 years ago

another good thing: @simoncozens mentioned at https://github.com/googlefonts/fontbakery-ui/issues/5 that this repo was setup to automatically build MacOS ZIP packages for tagged commits and automatically upload them as releases hosted in this repo (see "Releases" on the right column of the page).

I will soon release FontBakery 0.7.35 and then I will tag this repo with v0.7.35 to verify if this setup is still in good working condition. If that works well, then I will plan to always use the same version number for both projects so that it is easy to understand what's running under the hood, and also easier for users to report issues.

We may append a -n suffix if we have more than a single build of the UI for a given FontBakery core release. Such as FB UI v0.7.35, v0.7.35-1, v0.7.35-2, etc... But hopefully that won't be needed too often.

davelab6 commented 3 years ago

All sounds great, thank you