search

googlefonts / fontc

Where in we pursue oxidizing (context: https://github.com/googlefonts/oxidize) fontmake.
Apache License 2.0
85 stars 14 forks source link

Fix bug where fontc didn't have Glyphs-specific underline defaults #1007

Closed rsheeter closed 1 month ago

rsheeter commented 1 month ago

fontc and fontmake disagree about yStrikeoutSize for soft-type-jacquard/sources/Jacquard24Charted.glyphs.

In outlineCompiler.py in ufo2ft yStrikeoutSize is set to openTypeOS2StrikeoutSize if present, otherwise postscriptUnderlineThickness. Turns out https://github.com/googlefonts/glyphsLib/blob/9d5828d874110c42dfc5f542db8eb84f88641eb5/Lib/glyphsLib/builder/custom_params.py#L1136-L1156 captures parameters that differ from the ufo2ft defaults, notably underline thickness and position.

After this fix OS/2 and post match for Jacquard 24 Charted. Presumably impacts others too.