googlefonts / fontc

Where in we pursue oxidizing (context: https://github.com/googlefonts/oxidize) fontmake.
Apache License 2.0
85 stars 14 forks source link

Name 'standard' axes to match fonttools #1032

Closed anthrotype closed 1 month ago

anthrotype commented 1 month ago

Part of fixing https://github.com/googlefonts/fontc/issues/1020

This makes so that we follow fonttools' axis naming of a special group of registered axes, conventions still used by some old source files.

The remaining part of #1020 requires norad to support parsing of <labelname> element.

anthrotype commented 1 month ago

reproducer:

https://github.com/googlefonts/fontc/actions/runs/11326676896/job/31496101459?pr=1032#step:4:433

Diff < left / right > :
 [
<    "Weight",
<    "Width",
<    "Italic",
<    "Slant",
<    "Optical Size",
>    "weight",
>    "width",
>    "italic",
>    "slant",
>    "optical",
     "foobarbaz",
 ]
anthrotype commented 1 month ago

after this PR, https://github.com/weiweihuanghuang/Work-Sans Work-Sans-Italic.glyphs reports identical name, fvar and STAT tables in ttx_diff.py