googlefonts / fontc

Where in we pursue oxidizing (context: https://github.com/googlefonts/oxidize) fontmake.
Apache License 2.0
83 stars 13 forks source link

Crater errors aren't entirely helpful #1038

Open rsheeter opened 2 weeks ago

rsheeter commented 2 weeks ago

I don't know whether this is a user error or if I should Do Something to fix it:

Bad URL: failed to parse URL: RelativeUrlWithoutBase: relative URL without a base                                                                             
command failed: 'Cloning into './font_repos/Alegreya'...                                                                                                      
fatal: could not read Username for 'https://github.com': terminal prompts disabled
'
command failed: 'Cloning into './font_repos/elsiefont (404)'...                                                                                               
fatal: unable to access 'https://github.com/googlefonts/elsiefont (404)/': URL rejected: Malformed input to a URL function
'
command failed: 'Cloning into './font_repos/glory'...                                                                                                         
fatal: could not read Username for 'https://github.com': terminal prompts disabled
'
command failed: 'Cloning into './font_repos/manrope'...                                                                                                       
fatal: could not read Username for 'https://github.com': terminal prompts disabled
'
command failed: 'Cloning into './font_repos/Orelega'...                                                                                                       
fatal: could not read Username for 'https://github.com': terminal prompts disabled

My local cache dir seems well populated so maybe these are just bad sources...?

cmyr commented 2 weeks ago

What command did you run to see this? This is mostly telling you that we couldn't check out a repository because it is private (hence it is asking for your username/password) and I would only expect to see this when it is trying to build up the initial repo list.

There's nothing really actionable here.

rsheeter commented 2 weeks ago

I think just compile but probably any command with no local repos would do it. I was unclear from the output if this was normal or not.

cmyr commented 2 weeks ago

okay yea I need to rework/simplify the source finding a bit... I think part of the issue here is that you don't get context without logging enabled, and the messages you're seeing are actually being generated by a child git process that's inherited our stdout.