googlefonts / fontc

Where in we pursue oxidizing (context: https://github.com/googlefonts/oxidize) fontmake.
Apache License 2.0
85 stars 14 forks source link

crater should skip sources that have multiple masters but `buildVariable` set to false #1073

Closed cmyr closed 3 weeks ago

cmyr commented 4 weeks ago

We should probably be skipping these files in both modes, but they are particularly obvious in gftools mode since they turn into compile failures.

Figuring out whether or not a source has multiple masters will involve actually loading the source, but that's probably something we were going to have to do anyway.

rsheeter commented 4 weeks ago

Per VC I don't think we should skip these, reporting them as failures is more or less correct