googlefonts / fontc

Where in we pursue oxidizing (context: https://github.com/googlefonts/oxidize) fontmake.
Apache License 2.0
62 stars 10 forks source link

Handling of glyphs with no unicode values for the purposes of mark generation #812

Closed cmyr closed 1 month ago

cmyr commented 1 month ago

I don't fully understand this issue yet, but fontc is treating some glyphs as bases where fontmake is not; all of the glyphs in question have the property that they are not assigned a unicode value.

Do we compile these glyphs? Are they reachable via substitution? Should we be filtering the input glyphs for mark generation at some earlier stage?

cmyr commented 1 month ago

It turns out I have completely misunderstood this issue; the problem wasn't that fontc was treating these as bases but that it wasn't (and fonttools was; I misread the diff) and the root cause wasn't the absence of unicode values but the absence of explicit glyph categories; fix shortly.