googlefonts / fontc

Where in we pursue oxidizing (context: https://github.com/googlefonts/oxidize) fontmake.
Apache License 2.0
62 stars 10 forks source link

deduplicate identical lookups in GSUB/GPOS #830

Closed cmyr closed 1 month ago

cmyr commented 1 month ago

currently if the user defines two identical lookups we will assign each a unique lookup id (although the tables themselves will be deduplicated during table packing).

This is the source of some difference in GSUB ttx for oswald.

cmyr commented 1 month ago

This issue is imprecise; duplicate lookups can be meaningful (because of lookup order) and the real issue in the GSUB diff had more to do with how we combine rules in contextual lookups, which is improved in #842.