search

googlefonts / fontmake

Compile fonts from sources (UFO, Glyphs) to binary (OpenType, TrueType).
Apache License 2.0
783 stars 93 forks source link

Couldn't merge the fonts, inconsistent GDEF.table.MarkGlyphSetsDef #1036

Open anthrotype opened 1 year ago

anthrotype commented 1 year ago

originally reported by @rsms at https://github.com/googlefonts/fontmake/issues/894#issuecomment-1699524088, filing as separate issue as reminder to fix and as well as aid for others who may stumble on it.

The error is triggered by the following change in ufo2ft kernFeatureWriter https://github.com/googlefonts/ufo2ft/pull/720

@simoncozens suggested a workaround

The simple solution is to zero the width of the commabelowcomb in all masters. Currently they're treated as zero-width marks in some masters but not in others.

anthrotype commented 1 year ago

it would be nicer if we (ufo2ft probably) detect this situation early on and suggest the user a way to overcome it