search

googlefonts / fontmake

Compile fonts from sources (UFO, Glyphs) to binary (OpenType, TrueType).
Apache License 2.0
789 stars 94 forks source link

fontmake:Failed to remove overlaps for NotoNastaliqUrdu-Regular: 'uni0699' #192

Open marekjez86 opened 8 years ago

marekjez86 commented 8 years ago

The glyphs file was created by taking a NotoNastaliqUrdu.glyphs.ttf file into glyphs.app and saving it as gNotoNastaliqUrdu.glyphs

gNotoNastaliqUrdu.glyphs.zip

ERROR:fontmake:Failed to remove overlaps for NotoNastaliqUrdu-Regular: 'uni0699' raise InvalidSubjectContourError("contour %d is invalid for clipping" % i) booleanOperations.exceptions.InvalidSubjectContourError: contour 1 is invalid for clipping

R_ehS_ep.glif.zip

NotoNastaliqUrdu-Regular.ufo.zip

anthrotype commented 8 years ago

I'm not sure how you are getting that booleanOperation error.

I just downloaded the attached glyphs file and run the latest fontmake on it (I pulled master, and installed fontmake's requirements.txt in a new virtual env).

I could not reproduce the error, but actually got another (unrelated) error:

fontTools.feaLib.error.FeatureLibError: master_ufo/NotoNastaliqUrdu-Regular.ufo/features.fea:561:8: "dflt" is not a valid script tag; use "DFLT" instead

The attached .glif file seems to only contain a single contour, so booleanOperations should leave it untouched (and that's what it does, at least as far as I can reproduce).