googlefonts / fontmake

Compile fonts from sources (UFO, Glyphs) to binary (OpenType, TrueType).
Apache License 2.0
770 stars 93 forks source link

noto_lint.py <name/*> errors #45

Open marekjez86 opened 8 years ago

marekjez86 commented 8 years ago

I'm not sure if these <name/ attributes are generated or just passed from the glyphs input file (cc @dougfelt ), but noto_lint.py generates errors (the following were from linting NotoSansArmenianCondensed-Bold.otf )

E <name/family> The family is 'Noto Sans Armenian Condensed' but was expecting 'Noto Sans Armenian Condensed Bold' E <name/postscript_name> The postscript name is 'NotoSansArmenianCondensed-Bold' but was expecting 'NotoSansArmenian-CondensedBold' E <name/preferred_family> The preferred family is not set, but was expecting 'Noto Sans Armenian' E <name/preferred_subfamily> The preferred subfamily is not set, but was expecting 'Condensed Bold' E <name/subfamily> The subfamily is 'Bold' but was expecting 'Regular' E <name/trademark> The trademark is 'Noto is a trademark of Google Inc. and may be registered in certain jurisdictions.' but was expecting 'Noto is a trademark of Google Inc.' E <name/vendor_url> The vendor url is 'http://code.google.com/p/noto/' but was expecting 'http://www.google.com/get/noto/'

marekjez86 commented 8 years ago

BTW, here's a complete list of lint errors for NotoSansArmenianCondensed-Bold.otf (again: I'm not certain, except for the obvious [e.g. characters missing from the font], which attributes are generated and which just passed from the glyphs input file):

E <cmap/script_required> The following 15 characters are missing from the font: 0028..0029, 002C..002E, 003F, 00A7, 00AB, 00BB, 02BB, 2010, 2014, 2019, 2024, 2026. E <cmap/tables/unexpected> 'cmap' has a subtable of (format=4, platform=0, encoding=3), which it shouldn't have. E <head/hhea/ascent> Value of ascent in 'hhea' table is 1068, but should be 2189. E <head/hhea/descent> Value of descent in 'hhea' table is 292, but should be -600. E <head/os2/descender> Value of sTypoDescender in 'OS/2' table (-292) is different from the value of Descent in 'hhea' table (292), but they should be equal. E <head/os2/fstype> Value of fsType in the 'OS/2' table is 0x0008, but should be 0. E <head/os2/windescent> Value of usWinDescent in 'OS/2' table (292) is different from the opposite of value of Descent in 'hhea' table (292), but they should be opposites. E <name/description> The description is not set, but was expecting it to match '^Data unhinted. Designed by Monotype design team.$' E <name/designer> The designer is 'Monotype Design team' but was expecting 'Monotype Design Team' E <name/family> The family is 'Noto Sans Armenian Condensed' but was expecting 'Noto Sans Armenian Condensed Bold' E <name/postscript_name> The postscript name is 'NotoSansArmenianCondensed-Bold' but was expecting 'NotoSansArmenian-CondensedBold' E <name/preferred_family> The preferred family is not set, but was expecting 'Noto Sans Armenian' E <name/preferred_subfamily> The preferred subfamily is not set, but was expecting 'Condensed Bold' E <name/subfamily> The subfamily is 'Bold' but was expecting 'Regular' E <name/trademark> The trademark is 'Noto is a trademark of Google Inc. and may be registered in certain jurisdictions.' but was expecting 'Noto is a trademark of Google Inc.' E <name/vendor_url> The vendor url is 'http://code.google.com/p/noto/' but was expecting 'http://www.google.com/get/noto/' E <name/version> The version is '1.000' but was expecting it to match '^Version ([0-2]).(\d{2}) uh(?:;.*)?$'

anthrotype commented 7 years ago

@marekjez86 is this a fontmake issue, or just a font issue (i.e. source data not matching expectation of the linting tool)?