search

googlefonts / fontmake

Compile fonts from sources (UFO, Glyphs) to binary (OpenType, TrueType).
Apache License 2.0
782 stars 93 forks source link

Glyphs.app Smart Components misplaced in fontmaked VF #631

Open yanone opened 4 years ago

yanone commented 4 years ago

A Glyphs source I’m working on has Smart Components in various glyphs such as the Peso sign (open in that Glyphs file’s tab).

The font when generated through fontmake shows these components fully expanded when instead they should be rather contracted. Since the same file shows correctly placed components when exported directly from Glyphs as VF, I assume that this is a minor lapse in fontmake.

Glyph:

Bildschirmfoto 2020-01-23 um 13 32 11

Screenshot of VF exported through fontmake:

Bildschirmfoto 2020-01-23 um 13 32 18

Screenshot of VF exported through Glyphs:

Bildschirmfoto 2020-01-23 um 13 36 56
anthrotype commented 4 years ago

I'm afraid smart components are not supported at the moment. https://github.com/googlefonts/glyphsLib/issues/91

m4rc1e commented 2 years ago

@anthrotype what are your thoughts on raising an error if a user attempts to build a font which has smart components?

Just tried to generate Inconsolata and it ignored the smart components.

Screenshot 2022-05-25 at 08 44 13

Source: top spur of "C"

Screenshot 2022-05-25 at 08 44 49

Generated ttf:smart component skipped

This also caused the VTT hints to break which took me a while to figure so an error would be greatly appreciated.

More than happy to add this.

smart_comp_test.glyphs.zip