search

googlefonts / fontra

A browser-based font editor
https://fontra.xyz
GNU General Public License v3.0
493 stars 21 forks source link

Implement note field for glyph #1494

Closed ollimeier closed 3 months ago

ollimeier commented 3 months ago

Fixes #964

ollimeier commented 3 months ago

How do we deal with tooltips like that:

Screenshot 2024-06-27 at 18 29 15

Is this issue a follow up for the 'translation'-feature?

justvanrossum commented 3 months ago

How do we deal with tooltips like that:

I think it's best if we just add the english version to both language files for now. I want to manage the translations in a spreadsheet, maybe we can set that up later this month.

ollimeier commented 3 months ago

How do we deal with tooltips like that:

I think it's best if we just add the english version to both language files for now. I want to manage the translations in a spreadsheet, maybe we can set that up later this month.

OK, thanks. Done.

ollimeier commented 3 months ago

I haven't properly reviewed the code, but when trying it out I notice a regression: the up/down arrow keys no longer work, anywhere it seems:

  • canvas on selected points
  • glyph source list
  • glyph search results

Great finding. And Sorry for that. That was unnecessary misbehaviour. I fixed it.

justvanrossum commented 3 months ago

I've found a bug:

This was deeper than I thought: when clicking on the canvast, the current glyph changes, and our edit func is only called then, so we wouldn't have the (correct) selected glyph anymore. I had to add a new edit method on SceneController, and change some internals there: https://github.com/googlefonts/fontra/pull/1494/commits/ec5611637eb001753cee9b8525f7886a0a96ff6e & https://github.com/googlefonts/fontra/pull/1494/commits/4fddcd606337c5d8179f59a0bd5deae34c3ad89a